Switch to zookeeper of helm 3.0x #7955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongxiaoman
commented
Dec 22, 2021
| @@ -398,6 +398,7 @@ following configurable parameters: | |||
| | `zookeeper.resources` | Zookeeper resource requests and limits | `{}` | | |||
| | `zookeeper.env` | Environmental variables provided to Zookeeper Zookeeper | `{ZK_HEAP_SIZE: "256M"}` | | |||
| | `zookeeper.storage` | Zookeeper Persistent volume size | `2Gi` | | |||
| | `zookeeper.image.tag` | Zookeeper Image Version | |||
There was a problem hiding this comment.
by setting this value here it is possible to still use the Helm 2.x
xiangfu0
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now the pinot quick-start example in Apache Pinot doc is not starting anymore, because of zookeeper image deleted
Is because the latest zookeeper image version(tag) via Helm 2.x is deleted (my guess is because of log4j version), and nobody is maintaining the Helm 2.x chart any more.
Now we switch to use the images from helm 3.x
Note about License
Bitnami license is Apache License located under https://github.com/bitnami/charts
https://artifacthub.io/ license is also Apache License 2.0 via https://artifacthub.io/packages/helm/bitnami/zookeeper
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation